Fix hydrateMessages silently dropping user messages - #8442
Open
cstns wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8442 +/- ##
=======================================
Coverage 76.77% 76.77%
=======================================
Files 460 460
Lines 24703 24703
Branches 6573 6573
=======================================
Hits 18966 18966
Misses 5737 5737
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
force-pushed
the
fix-hydrate-messages-user-drop
branch
from
September 7, 2026 15:04
ed6a133 to
95eb61a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while building the onboarding surface, but this is shipped behaviour:
hydrateMessagesin the product-expert store rehydrates a saved transcript with aswitch (true), which matches cases by strict equality. TheisUserMessagepredicate returnedhasOwnProperty && message.query, which evaluates to the query string rather than a boolean, so it never strictly equalstrueand every user message is silently skipped. The AI branch only works becauseArray.isArrayhappens to return a real boolean.In practice this means the editor to platform conversation handoff (
wakeUpAssistantwithshouldHydrateMessages) rebuilds the transcript with the assistant's answers but none of the user's messages.Both predicates now return actual booleans, with a comment explaining why that matters, plus a regression spec that hydrates a mixed transcript and asserts the message sequence.